From 2f444efdaaed82f69d0afc4a7038a8563d8a3fa1 Mon Sep 17 00:00:00 2001
From: Jonathan Corbet <corbet@lwn.net>
Date: Mon, 22 Jun 2020 16:31:21 -0600
Subject: [PATCH] docs: Don't push Sphinx upgrades quite so readily
The sphinx-pre-install script will put out a verbose message recommending
an upgrade for anybody running less than 2.4.4 - which was only released in
March. So *everybody* will see that warning at this point. Let's only
warn if the user is below our generally recommended version (1.7.9
currently).
It might be good to put out a warning if people are explicitly making PDF
files, but would need to be done in a different place and relatively few
people do that.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
---
scripts/sphinx-pre-install | 4 ----
1 file changed, 4 deletions(-)
diff --git a/scripts/sphinx-pre-install b/scripts/sphinx-pre-install
index c680c3efb176e..40fa6923e80ae 100755
--- a/scripts/sphinx-pre-install
+++ b/scripts/sphinx-pre-install
@@ -323,10 +323,6 @@ sub check_sphinx()
$rec_sphinx_upgrade = 1;
return;
}
- if ($cur_version lt $min_pdf_version) {
- $rec_sphinx_upgrade = 1;
- return;
- }
# On version check mode, just assume Sphinx has all mandatory deps
exit (0) if ($version_check);
--
GitLab