From 46a53371f3fd9bf873fdd9c4df75b1cd86df1098 Mon Sep 17 00:00:00 2001
From: Donghai Qiao <dqiao@redhat.com>
Date: Fri, 14 Jan 2022 14:05:32 -0800
Subject: [PATCH] mm/page_counter: remove an incorrect call to
propagate_protected_usage()
propagate_protected_usage() is called to propagate the usage change in
the page_counter structure. But there is a call to this function from
page_counter_try_charge() when there is actually no usage change. Hence
this call should be removed.
Link: https://lkml.kernel.org/r/20211118181125.3918222-1-dqiao@redhat.com
Signed-off-by: Donghai Qiao <dqiao@redhat.com>
Reviewed-by: Roman Gushchin <guro@fb.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
mm/page_counter.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/page_counter.c b/mm/page_counter.c
index 7d83641eb86b7..eb156ff5d6030 100644
--- a/mm/page_counter.c
+++ b/mm/page_counter.c
@@ -120,7 +120,6 @@ bool page_counter_try_charge(struct page_counter *counter,
new = atomic_long_add_return(nr_pages, &c->usage);
if (new > c->max) {
atomic_long_sub(nr_pages, &c->usage);
- propagate_protected_usage(c, new);
/*
* This is racy, but we can live with some
* inaccuracy in the failcnt which is only used
--
GitLab