From d3465af60f4471b7b6201928e709bc137fdbee3e Mon Sep 17 00:00:00 2001 From: Ulf Magnusson <ulfalizer@gmail.com> Date: Sun, 14 Jan 2018 15:12:05 +0100 Subject: [PATCH] kconfig: Clarify choice dependency propagation It's easy to miss that choices are special-cased to pass on their mode as the parent dependency. No functional changes. Only comments added. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/kconfig/menu.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index 7634d567e7794..dcf22008b2d6e 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -323,6 +323,13 @@ void menu_finalize(struct menu *parent) if (menu->sym && menu->sym->type == S_UNKNOWN) menu_set_type(sym->type); } + + /* + * Use the choice itself as the parent dependency of + * the contained items. This turns the mode of the + * choice into an upper bound on the visibility of the + * choice value symbols. + */ parentdep = expr_alloc_symbol(sym); } else if (parent->prompt) parentdep = parent->prompt->visible.expr; -- GitLab