From e2d8680741edec84f843f783a7f4a44418b818d7 Mon Sep 17 00:00:00 2001 From: Moritz Fischer <moritz.fischer@ettus.com> Date: Thu, 29 Oct 2015 08:56:31 -0700 Subject: [PATCH] fpga: socfpga: Fix check of return value of devm_request_irq The return value should be checked for non-zero, instead of checking it being IS_ERR_VALUE(). Acked-by: Alan Tull <atull@opensource.altera.com> Reviewed-by: Josh Cartwright <joshc@eso.teric.us> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/fpga/socfpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c index 706b80d25266b..27d2ff28132c2 100644 --- a/drivers/fpga/socfpga.c +++ b/drivers/fpga/socfpga.c @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev) ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0, dev_name(dev), priv); - if (IS_ERR_VALUE(ret)) + if (ret) return ret; return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager", -- GitLab