Skip to content
Snippets Groups Projects
Commit ff6c032e authored by Heiko Schocher's avatar Heiko Schocher Committed by Tom Rini
Browse files

spl: fix calling "spl export .." more than once


running "spl export ..." more than once fails with:

Trying to execute a command out of order
Trying to execute a command out of order
Trying to execute a command out of order
Trying to execute a command out of order
Trying to execute a command out of order
Trying to execute a command out of order
ERROR prep subcommand failed!
Subcommand failed

reason is commmit:
35fc84fa: Refactor the bootm command to reduce code duplication

It used "state != BOOTM_STATE_START" but state is a bitfield, so
check if the bit BOOTM_STATE_START is not set. With this fix,
"spl export ..." can called more than once ...

Signed-off-by: default avatarHeiko Schocher <hs@denx.de>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
parent 14f264e6
No related branches found
No related tags found
No related merge requests found
......@@ -78,7 +78,8 @@ static int do_bootm_subcommand(cmd_tbl_t *cmdtp, int flag, int argc,
return CMD_RET_USAGE;
}
if (state != BOOTM_STATE_START && images.state >= state) {
if (((state & BOOTM_STATE_START) != BOOTM_STATE_START) &&
images.state >= state) {
printf("Trying to execute a command out of order\n");
return CMD_RET_USAGE;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment