Skip to content
Snippets Groups Projects
  1. Aug 10, 2013
  2. Feb 08, 2013
  3. Oct 15, 2012
  4. Apr 13, 2010
  5. Apr 01, 2009
    • David Gibson's avatar
      libfdt: Rework/cleanup fdt_next_tag() · a22d9cfb
      David Gibson authored
      
      Currently, callers of fdt_next_tag() must usually follow the call with
      some sort of call to fdt_offset_ptr() to verify that the blob isn't
      truncated in the middle of the tag data they're going to process.
      This is a bit silly, since fdt_next_tag() generally has to call
      fdt_offset_ptr() on at least some of the data following the tag for
      its own operation.
      
      This patch alters fdt_next_tag() to always use fdt_offset_ptr() to
      verify the data between its starting offset and the offset it returns
      in nextoffset.  This simplifies fdt_get_property() which no longer has
      to verify itself that the property data is all present.
      
      At the same time, I neaten and clarify the error handling for
      fdt_next_tag().  Previously, fdt_next_tag() could return -1 instead of
      a tag value in some circumstances - which almost none of the callers
      checked for.  Also, fdt_next_tag() could return FDT_END either because
      it encountered an FDT_END tag, or because it reached the end of the
      structure block - no way was provided to tell between these cases.
      
      With this patch, fdt_next_tag() always returns FDT_END with a negative
      value in nextoffset for an error.  This means the several places which
      loop looking for FDT_END will still work correctly - they only need to
      check for errors at the end.  The errors which fdt_next_tag() can
      report are:
      	- -FDT_ERR_TRUNCATED if it reached the end of the structure
      	   block instead of finding a tag.
      
      	- -FDT_BADSTRUCTURE if a bad tag was encountered, or if the
                 tag data couldn't be verified with fdt_offset_ptr().
      
      This patch also updates the callers of fdt_next_tag(), where
      appropriate, to make use of the new error reporting.
      
      Finally, the prototype for the long gone _fdt_next_tag() is removed
      from libfdt_internal.h.
      
      Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      a22d9cfb
  6. Aug 25, 2008
    • David Gibson's avatar
      libfdt: Increase namespace-pollution paranoia · fc7758ee
      David Gibson authored
      
      libfdt is supposed to easy to embed in projects all and sundry.
      Often, it won't be practical to separate the embedded libfdt's
      namespace from that of the surrounding project.  Which means there can
      be namespace conflicts between even libfdt's internal/static functions
      and functions or macros coming from the surrounding project's headers
      via libfdt_env.h.
      
      This patch, therefore, renames a bunch of libfdt internal functions
      and macros and makes a few other chances to reduce the chances of
      namespace collisions with embedding projects.  Specifically:
      	- Internal functions (even static ones) are now named _fdt_*()
      
      	- The type and (static) global for the error table in
                fdt_strerror() gain an fdt_ prefix
      
      	- The unused macro PALIGN is removed
      
      	- The memeq and streq macros are removed and open-coded in the
                users (they were only used once each)
      
      	- Other macros gain an FDT_ prefix
      
      	- To save some of the bulk from the previous change, an
                FDT_TAGALIGN() macro is introduced, where FDT_TAGALIGN(x) ==
                FDT_ALIGN(x, FDT_TAGSIZE)
      
      Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      fc7758ee
    • David Gibson's avatar
      dtc: Enable and fix -Wcast-qual warnings · c6683026
      David Gibson authored
      
      Enabling -Wcast-qual warnings in dtc shows up a number of places where
      we are incorrectly discarding a const qualification.  There are also
      some places where we are intentionally discarding the 'const', and we
      need an ugly cast through uintptr_t to suppress the warning.  However,
      most of these are pretty well isolated with the *_w() functions.  So
      in the interests of maximum safety with const qualifications, this
      patch enables the warnings and fixes the existing complaints.
      
      Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      Acked-by: default avatarGerald Van Baren <vanbaren@cideas.com>
      c6683026
    • David Gibson's avatar
      dtc: Enable and fix -Wpointer-arith warnings · ef4e8ce1
      David Gibson authored
      
      This patch turns on the -Wpointer-arith option in the dtc Makefile,
      and fixes the resulting warnings due to using (void *) in pointer
      arithmetic.  While convenient, pointer arithmetic on void * is not
      portable, so it's better that we avoid it, particularly in libfdt.
      
      Also add necessary definition of uintptr_t needed by David Gibson's
      changeset "dtc: Enable and fix -Wpointer-arith warnings" (the definition
      comes from stdint.h, which u-boot doesn't have). -- gvb
      
      Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      Signed-off-by: default avatarGerald Van Baren <vanbaren@cideas.com>
      ef4e8ce1
  7. Jun 10, 2008
    • David Gibson's avatar
      libfdt: Several cleanups to parameter checking · 2f08bfa9
      David Gibson authored
      
      This patch makes a couple of small cleanups to parameter checking of
      libfdt functions.
      
      	- In several functions which take a node offset, we use an
      idiom involving fdt_next_tag() first to check that we have indeed been
      given a node offset.  This patch adds a helper function
      _fdt_check_node_offset() to encapsulate this usage of fdt_next_tag().
      
      	- In fdt_rw.c in several places we have the expanded version
      of the RW_CHECK_HEADER() macro for no particular reason.  This patch
      replaces those instances with an invocation of the macro; that's what
      it's for.
      
      	- In fdt_sw.c we rename the check_header_sw() function to
      sw_check_header() to match the analgous function in fdt_rw.c, and we
      provide an SW_CHECK_HEADER() wrapper macro as RW_CHECK_HEADER()
      functions in fdt_rw.c
      
      Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      2f08bfa9
  8. Mar 19, 2008
  9. Feb 29, 2008
  10. Jan 08, 2008
    • Gerald Van Baren's avatar
      LIBFDT: use memmove() instead of memcpy() · ad3006fe
      Gerald Van Baren authored
      
      This is partial patch from the DTC/libfdt
      commit  67b6b33b9b413a450a72135b5dc59c0a1e33e647
      Author: David Gibson <david@gibson.dropbear.id.au>
      Date:   Wed Nov 21 11:56:14 2007 +1100
      
          The patch also fixes one genuine bug caught by valgrind -
          _packblocks() in fdt_rw.c was using memcpy() where it should have been
          using memmove().
      
      Signed-off-by: default avatarGerald Van Baren <vanbaren@cideas.com>
      ad3006fe
  11. Nov 21, 2007
  12. Sep 06, 2007
  13. Aug 10, 2007
  14. Apr 06, 2007
  15. Mar 31, 2007
Loading