Skip to content
Snippets Groups Projects
  1. Nov 25, 2014
  2. Nov 24, 2014
  3. Nov 23, 2014
  4. Nov 21, 2014
  5. Nov 19, 2014
  6. Nov 17, 2014
  7. Nov 12, 2014
  8. Nov 08, 2014
  9. Nov 07, 2014
    • Wolfgang Denk's avatar
      common/cmd_fitupd.c: restore corrupted file · 1aaab00d
      Wolfgang Denk authored
      
      This file got corrupted by the automatic editin of commit 1a459660 "Add
      GPL-2.0+ SPDX-License-Identifier to source files"; restore the
      opiginal content and manually insert the SPDX ID.
      
      The bug was detected by running cppcheck, which reported:
      [common/cmd_fitupd.c:8]: (error) Invalid number of character ({) when
      these macros are defined: 'CONFIG_UPDATE_TFTP'.
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      1aaab00d
    • Rabin Vincent's avatar
      hush: make run_command() return an error on parsing failure · 2302b3ab
      Rabin Vincent authored
      
      run_command() returns success even if the command had a syntax error;
      correct this behaviour.
      
      Signed-off-by: default avatarRabin Vincent <rabin@rab.in>
      Acked-by: default avatarSimon Glass <sjg@chromium.org)>
      2302b3ab
    • Rabin Vincent's avatar
      hush: fix segfault on syntax error · 128059b9
      Rabin Vincent authored
      
      Hush segfaults if it sees a syntax error while attempting to parse a
      command:
      
       $ ./u-boot -c "'"
       ...
       syntax error
       Segmentation fault (core dumped)
      
      This is due to a NULL pointer dereference of in_str->p in static_peek().
      The problem is that the exit condition for the loop in
      parse_stream_outer() checks for rcode not being -1, but rcode is only
      ever 0 or 1.
      
      Signed-off-by: default avatarRabin Vincent <rabin@rab.in>
      Acked-by: default avatarSimon Glass <sjg@chromium.org)>
      Tested-by: default avatarSimon Glass <sjg@chromium.org)>
      128059b9
    • Rabin Vincent's avatar
      hush: return consistent codes from run_command() · 484408fb
      Rabin Vincent authored
      
      Attempting to run:
       - an empty string
       - a string with just spaces
      
      returns different error codes, 1 for the empty string and 0
      for the string with just spaces.  Make both of them return
      0 for consistency.
      
      Signed-off-by: default avatarRabin Vincent <rabin@rab.in>
      Acked-by: default avatarSimon Glass <sjg@chromium.org)>
      484408fb
    • Rabin Vincent's avatar
      dlmalloc: ensure gd is set for early alloc · 854d2b97
      Rabin Vincent authored
      
      Attempting to run the sandbox leads to a segfault, because some dynamic
      libraries (outside of u-boot) attempt to use malloc() to allocate memory
      before u-boot's gd variable is initialized.
      
      Check for gd not being NULL in the SYS_MALLOC_F_LEN handling, so that
      malloc() doesn't crash when called at this point.
      
       $ gdb -q --args ./u-boot
       (gdb) r
       Program received signal SIGSEGV, Segmentation fault.
       0x0000000000412b9b in malloc (bytes=bytes@entry=37) at common/dlmalloc.c:2184
       2184		if (!(gd->flags & GD_FLG_RELOC)) {
       (gdb) p gd
       $1 = (gd_t *) 0x0
       (gdb) bt
       #0  0x0000000000412b9b in malloc (bytes=bytes@entry=37) at common/dlmalloc.c:2184
       #1  0x00007ffff75bf8e1 in set_binding_values (domainname=0x7ffff11f4f12 "libgpg-error", dirnamep=0x7fffffffe168, codesetp=0x0)
           at bindtextdom.c:228
       #2  0x00007ffff75bfb4c in set_binding_values (codesetp=0x0, dirnamep=0x7fffffffe168, domainname=<optimized out>) at bindtextdom.c:350
       #3  __bindtextdomain (domainname=<optimized out>, dirname=0x7ffff11f4f00 "/usr/share/locale") at bindtextdom.c:348
       #4  0x00007ffff11eca17 in ?? () from /lib/x86_64-linux-gnu/libgpg-error.so.0
       #5  0x00007ffff7dea9fa in call_init (l=<optimized out>, argc=argc@entry=1, argv=argv@entry=0x7fffffffe208,
           env=env@entry=0x7fffffffe218) at dl-init.c:78
       #6  0x00007ffff7deaae3 in call_init (env=0x7fffffffe218, argv=0x7fffffffe208, argc=1, l=<optimized out>) at dl-init.c:36
       #7  _dl_init (main_map=0x7ffff7ffe1a8, argc=1, argv=0x7fffffffe208, env=0x7fffffffe218) at dl-init.c:126
       #8  0x00007ffff7ddd1ca in _dl_start_user () from /lib64/ld-linux-x86-64.so.2
      
      Signed-off-by: default avatarRabin Vincent <rabin@rab.in>
      Acked-by: default avatarSimon Glass <sjg@chromium.org>
      854d2b97
    • Noam Camus's avatar
      image-fdt: boot_get_fdt() return value when no DTB exists · c6150aaf
      Noam Camus authored
      
      I believe that when no DTB is around we should return 1.
      This why I fixed such scenarious to not return zero anymore.
      Else kernel might get NULL pointer to DTB which doesn't exists.
      
      Signed-off-by: default avatarNoam Camus <noamc@ezchip.com>
      c6150aaf
  10. Nov 04, 2014
Loading