Skip to content
Snippets Groups Projects
  1. Nov 04, 2012
    • Kim Phillips's avatar
      powerpc/mpc83xx: sparse fixes · a2873bde
      Kim Phillips authored
      
      fdt.c:91:78: warning: Using plain integer as NULL pointer
      fdt.c:103:78: warning: Using plain integer as NULL pointer
      speed.c:55:11: warning: symbol 'corecnf_tab' was not declared. Should it be static?
      speed.c:519:5: warning: symbol 'do_clocks' was not declared. Should it be static?
      mpc8313erdb.c:73:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:74:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:75:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:76:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:79:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:80:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:81:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:82:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:85:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:86:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:87:17: warning: obsolete struct initializer, use C99 syntax
      mpc8313erdb.c:88:17: warning: obsolete struct initializer, use C99 syntax
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      a2873bde
    • Kim Phillips's avatar
      powerpc/mpc85xx: sparse fixes · e56143e5
      Kim Phillips authored
      
      fsl_corenet_serdes.c:485:6: warning: symbol '__soc_serdes_init' was not declared. Should it be static?
      cpu_init.c:185:6: warning: symbol 'invalidate_cpc' was not declared. Should it be static?
      bcsr.c:28:27: warning: non-ANSI function declaration of function 'enable_8568mds_duart'
      bcsr.c:39:33: warning: non-ANSI function declaration of function 'enable_8568mds_flash_write'
      bcsr.c:46:34: warning: non-ANSI function declaration of function 'disable_8568mds_flash_write'
      bcsr.c:53:29: warning: non-ANSI function declaration of function 'enable_8568mds_qe_mdio'
      bcsr.c:28:33: warning: non-ANSI function declaration of function 'enable_8569mds_flash_write'
      bcsr.c:33:34: warning: non-ANSI function declaration of function 'disable_8569mds_flash_write'
      bcsr.c:38:28: warning: non-ANSI function declaration of function 'enable_8569mds_qe_uec'
      bcsr.c:63:47: warning: non-ANSI function declaration of function 'disable_8569mds_brd_eeprom_write_protect'
      ngpixis.c:245:1: error: directive in argument list
      ngpixis.c:247:1: error: directive in argument list
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      e56143e5
    • Kim Phillips's avatar
      arch/powerpc/cpu/mpc8xxx/: sparse fixes · 2ed2e912
      Kim Phillips authored
      
      ctrl_regs.c:31:5: warning: symbol 'fsl_ddr_get_version' was not declared. Should it be static?
      cpu.c:135:14: warning: non-ANSI function declaration of function 'cpu_mask'
      cpu.c:154:18: warning: non-ANSI function declaration of function 'cpu_numcores'
      cpu.c:37:17: warning: symbol 'cpu_type_list' was not declared. Should it be static?
      cpu.c:117:17: warning: symbol 'cpu_type_unknown' was not declared. Should it be static?
      fsl_lbc.c:14:6: warning: symbol '__lbc_sdram_init' was not declared. Should it be static?
      
      and:
      
      lc_common_dimm_params.c:15:1: warning: symbol 'compute_cas_latency_ddr3' was not declared. Should it be static?
      
      making it static produces the following compiler warning:
      
      lc_common_dimm_params.c:15:1: warning: 'compute_cas_latency_ddr3' defined but not used [-Wunused-function]
      
      so we protect it with the preprocessor.
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      2ed2e912
    • Kim Phillips's avatar
      arch/powerpc/lib/board.c, *traps.c: sparse fixes · 20051f2a
      Kim Phillips authored
      
      traps.c:*:1: warning: symbol 'print_backtrace' was not declared. Should it be static?
      traps.c:93:1: warning: symbol '_exception' was not declared. Should it be static?
      board.c:166:6: warning: symbol '__board_add_ram_info' was not declared. Should it be static?
      board.c:174:5: warning: symbol '__board_flash_wp_on' was not declared. Should it be static?
      board.c:187:6: warning: symbol '__cpu_secondary_init_r' was not declared. Should it be static?
      board.c:265:12: warning: symbol 'init_sequence' was not declared. Should it be static?
      board.c:348:5: warning: symbol '__fixup_cpu' was not declared. Should it be static?
      board.c:405:53: warning: Using plain integer as NULL pointer
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      20051f2a
    • Kim Phillips's avatar
      arch/powerpc/lib/extable.c: sparse fix · fe44f452
      Kim Phillips authored
      
      extable.c:66:9: warning: symbol 'ex_tab_message' was not declared. Should it be static?
      
      making it static can produce a new build warning on some boards:
      
      extable.c:66:12: warning: 'ex_tab_message' defined but not used [-Wunused-variable]
      
      but ex_tab_message doesn't do much even when used, so just remove it.
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      fe44f452
    • Kim Phillips's avatar
      arch/powerpc/include/asm/io.h: fix warning: preprocessor token __iomem redefined · cdfdb8d7
      Kim Phillips authored
      
      a fixup __iomem definition in arch code appears to be placed there as a cover
      up from a code import from linux when u-boot didn't yet have a compiler.h,
      introduced by commit 812711ce "Implement
      __raw_{read,write}[bwl] on all architectures".
      
      git show 812711ce:include/linux/compiler.h
      fatal: Path 'include/linux/compiler.h' exists on disk, but not in '812711ce'.
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      cdfdb8d7
    • Kim Phillips's avatar
      include/linux/byteorder: import latest endian definitions from linux · eef1cf2d
      Kim Phillips authored
      
      u-boot's byteorder headers did not contain endianness attributions
      for use with sparse, causing a lot of false positives.  Import the
      kernel's latest definitions, and enable them by including compiler.h
      and types.h.  They come with 'const' added for some swab functions, so
      fix those up, too:
      
      include/linux/byteorder/big_endian.h:46:2: warning: passing argument 1 of '__swab64p' discards 'const' qualifier from pointer target type [enabled by default]
      
      Also, note: u-boot's historic __BYTE_ORDER definition has been
      preserved (for the time being at least).
      
      We also remove ad-hoc barrier() definitions, since we're including
      compiler.h in files that hadn't in the past:
      
      macb.c:54:0: warning: "barrier" redefined [enabled by default]
      
      In addition, including compiler.h in byteorder changes the 'noinline'
      definition to expand to __attribute__((noinline)).  This fixes
      arch/powerpc/lib/bootm.c:
      
      bootm.c:329:16: error: attribute '__attribute__': unknown attribute
      bootm.c:329:16: error: expected ')' before '__attribute__'
      bootm.c:329:25: error: expected identifier or '(' before ')' token
      
      powerpc sparse builds yield:
      
      include/common.h:356:22: error: marked inline, but without a definition
      
      the unknown-reason inlining without a definition is considered obsolete
      given it was part of the 2002 initial commit, and no arm version was
      'fixed.'
      
      also fixed:
      ydirectenv.h:60:0: warning: "inline" redefined [enabled by default]
      
      and:
      
      Configuring for devconcenter - Board: intip, Options: DEVCONCENTER
      make[1]: *** [4xx_ibm_ddr2_autocalib.o] Error 1
      make: *** [arch/powerpc/cpu/ppc4xx/libppc4xx.o] Error 2
      powerpc-fsl-linux-size: './u-boot': No such file
      4xx_ibm_ddr2_autocalib.c: In function 'DQS_autocalibration':
      include/asm/ppc4xx-sdram.h:1407:13: sorry, unimplemented: inlining failed in call to 'ppc4xx_ibm_ddr2_register_dump': function body not available
      4xx_ibm_ddr2_autocalib.c:1243:32: sorry, unimplemented: called from here
      
      and:
      
      In file included from crc32.c:50:0:
      crc32table.h:4:1: warning: implicit declaration of function '___constant_swab32' [-Wimplicit-function-declaration]
      crc32table.h:4:1: error: initializer element is not constant
      crc32table.h:4:1: error: (near initialization for 'crc32table_le[0]')
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      [trini: Remove '#endif' in include/common.h around setenv portion]
      Signed-off-by: default avatarTom Rini <trini@ti.com>
      eef1cf2d
  2. Oct 28, 2012
  3. Oct 26, 2012
  4. Oct 25, 2012
  5. Oct 24, 2012
  6. Oct 23, 2012
  7. Oct 22, 2012
Loading