-
- Downloads
Unify type of "cpu_idx" across PSCI module.
NOTE for platform integrators:
API `plat_psci_stat_get_residency()` third argument
`last_cpu_idx` is changed from "signed int" to the
"unsigned int" type.
Issue / Trouble points
1. cpu_idx is used as mix of `unsigned int` and `signed int` in code
with typecasting at some places leading to coverity issues.
2. Underlying platform API's return cpu_idx as `unsigned int`
and comparison is performed with platform specific defines
`PLAFORM_xxx` which is not consistent
Misra Rule 10.4:
The value of a complex expression of integer type may only be cast to
a type that is narrower and of the same signedness as the underlying
type of the expression.
Based on above points, cpu_idx is kept as `unsigned int` to match
the API's and low-level functions and platform defines are updated
where ever required
Signed-off-by:
Deepika Bhavnani <deepika.bhavnani@arm.com>
Change-Id: Ib26fd16e420c35527204b126b9b91e8babcc3a5c
Showing
- docs/getting_started/porting-guide.rst 1 addition, 1 deletiondocs/getting_started/porting-guide.rst
- drivers/arm/css/scp/css_pm_scmi.c 3 additions, 2 deletionsdrivers/arm/css/scp/css_pm_scmi.c
- include/export/lib/utils_def_exp.h 3 additions, 1 deletioninclude/export/lib/utils_def_exp.h
- include/lib/psci/psci.h 1 addition, 1 deletioninclude/lib/psci/psci.h
- include/plat/arm/common/arm_def.h 1 addition, 1 deletioninclude/plat/arm/common/arm_def.h
- include/plat/common/platform.h 1 addition, 1 deletioninclude/plat/common/platform.h
- lib/psci/psci_main.c 8 additions, 5 deletionslib/psci/psci_main.c
- lib/psci/psci_off.c 2 additions, 2 deletionslib/psci/psci_off.c
- lib/psci/psci_on.c 13 additions, 11 deletionslib/psci/psci_on.c
- lib/psci/psci_private.h 3 additions, 3 deletionslib/psci/psci_private.h
- lib/psci/psci_setup.c 8 additions, 8 deletionslib/psci/psci_setup.c
- lib/psci/psci_stat.c 6 additions, 6 deletionslib/psci/psci_stat.c
- lib/psci/psci_suspend.c 4 additions, 4 deletionslib/psci/psci_suspend.c
- plat/arm/board/a5ds/include/platform_def.h 5 additions, 5 deletionsplat/arm/board/a5ds/include/platform_def.h
- plat/arm/board/corstone700/include/platform_def.h 3 additions, 3 deletionsplat/arm/board/corstone700/include/platform_def.h
- plat/arm/board/fvp/include/platform_def.h 6 additions, 5 deletionsplat/arm/board/fvp/include/platform_def.h
- plat/arm/board/fvp_ve/fvp_ve_def.h 5 additions, 5 deletionsplat/arm/board/fvp_ve/fvp_ve_def.h
- plat/arm/board/fvp_ve/include/platform_def.h 3 additions, 3 deletionsplat/arm/board/fvp_ve/include/platform_def.h
- plat/arm/board/juno/juno_def.h 4 additions, 4 deletionsplat/arm/board/juno/juno_def.h
- plat/arm/board/rde1edge/include/platform_def.h 3 additions, 3 deletionsplat/arm/board/rde1edge/include/platform_def.h
Loading
Please register or sign in to comment