Fix the CAS spinlock implementation
Make the spinlock implementation use ARMv8.1-LSE CAS instruction based on a platform build option. The CAS-based implementation used to be unconditionally selected for all ARM8.1+ platforms. The previous CAS spinlock implementation had a bug wherein the spin_unlock() implementation had an `sev` after `stlr` which is not sufficient. A dsb is needed to ensure that the stlr completes prior to the sev. Having a dsb is heavyweight and a better solution would be to use load exclusive semantics to monitor the lock and wake up from wfe when a store happens to the lock. The patch implements the same. Change-Id: I5283ce4a889376e4cc01d1b9d09afa8229a2e522 Signed-off-by:Soby Mathew <soby.mathew@arm.com> Signed-off-by:
Olivier Deprez <olivier.deprez@arm.com>
Showing
- Makefile 11 additions, 0 deletionsMakefile
- docs/design/firmware-design.rst 5 additions, 2 deletionsdocs/design/firmware-design.rst
- docs/getting_started/user-guide.rst 4 additions, 0 deletionsdocs/getting_started/user-guide.rst
- lib/locks/exclusive/aarch64/spinlock.S 18 additions, 35 deletionslib/locks/exclusive/aarch64/spinlock.S
- make_helpers/defaults.mk 5 additions, 0 deletionsmake_helpers/defaults.mk
Loading
Please register or sign in to comment