Skip to content
Snippets Groups Projects
  • Masahiro Yamada's avatar
    48dd6c71
    Rename .data.once to .data..once to fix resetting WARN*_ONCE · 48dd6c71
    Masahiro Yamada authored
    [ Upstream commit dbefa1f31a91670c9e7dac9b559625336206466f ]
    
    Commit b1fca27d ("kernel debug: support resetting WARN*_ONCE")
    added support for clearing the state of once warnings. However,
    it is not functional when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION or
    CONFIG_LTO_CLANG is enabled, because .data.once matches the
    .data.[0-9a-zA-Z_]* pattern in the DATA_MAIN macro.
    
    Commit cb87481e ("kbuild: linker script do not match C names unless
    LD_DEAD_CODE_DATA_ELIMINATION is configured") was introduced to suppress
    the issue for the default CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=n case,
    providing a minimal fix for stable backporting. We were aware this did
    not address the issue for CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y. The
    plan was to apply correct fixes and then revert cb87481e. [1]
    
    Seven years have passed since then, yet the #ifdef workaround remains in
    place. Meanwhile, commit b1fca27d introduced the .data.once section,
    and commit dc5723b0 ("kbuild: add support for Clang LTO") extended
    the #ifdef.
    
    Using a ".." separator in the section name fixes the issue for
    CONFIG_LD_DEAD_CODE_DATA_ELIMINATION and CONFIG_LTO_CLANG.
    
    [1]: https://lore.kernel.org/linux-kbuild/CAK7LNASck6BfdLnESxXUeECYL26yUDm0cwRZuM4gmaWUkxjL5g@mail.gmail.com/
    
    
    
    Fixes: b1fca27d ("kernel debug: support resetting WARN*_ONCE")
    Fixes: dc5723b0 ("kbuild: add support for Clang LTO")
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
    48dd6c71
    History
    Rename .data.once to .data..once to fix resetting WARN*_ONCE
    Masahiro Yamada authored
    [ Upstream commit dbefa1f31a91670c9e7dac9b559625336206466f ]
    
    Commit b1fca27d ("kernel debug: support resetting WARN*_ONCE")
    added support for clearing the state of once warnings. However,
    it is not functional when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION or
    CONFIG_LTO_CLANG is enabled, because .data.once matches the
    .data.[0-9a-zA-Z_]* pattern in the DATA_MAIN macro.
    
    Commit cb87481e ("kbuild: linker script do not match C names unless
    LD_DEAD_CODE_DATA_ELIMINATION is configured") was introduced to suppress
    the issue for the default CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=n case,
    providing a minimal fix for stable backporting. We were aware this did
    not address the issue for CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y. The
    plan was to apply correct fixes and then revert cb87481e. [1]
    
    Seven years have passed since then, yet the #ifdef workaround remains in
    place. Meanwhile, commit b1fca27d introduced the .data.once section,
    and commit dc5723b0 ("kbuild: add support for Clang LTO") extended
    the #ifdef.
    
    Using a ".." separator in the section name fixes the issue for
    CONFIG_LD_DEAD_CODE_DATA_ELIMINATION and CONFIG_LTO_CLANG.
    
    [1]: https://lore.kernel.org/linux-kbuild/CAK7LNASck6BfdLnESxXUeECYL26yUDm0cwRZuM4gmaWUkxjL5g@mail.gmail.com/
    
    
    
    Fixes: b1fca27d ("kernel debug: support resetting WARN*_ONCE")
    Fixes: dc5723b0 ("kbuild: add support for Clang LTO")
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>