Skip to content
Snippets Groups Projects
  • Ilya Dryomov's avatar
    b91a7bdc
    rbd: don't assert on writes to snapshots · b91a7bdc
    Ilya Dryomov authored
    
    The check added in commit 721c7fc7 ("block: fail op_is_write()
    requests to read-only partitions") was lifted in commit a32e236e
    ("Partially revert "block: fail op_is_write() requests to read-only
    partitions"").  Basic things like user triggered writes and discards
    are still caught, but internal kernel users can submit anything.  In
    particular, ext4 will attempt to write to the superblock if it detects
    errors in the filesystem, even if the filesystem is mounted read-only
    on a read-only partition.
    
    The assert is overkill regardless.
    
    Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
    b91a7bdc
    History
    rbd: don't assert on writes to snapshots
    Ilya Dryomov authored
    
    The check added in commit 721c7fc7 ("block: fail op_is_write()
    requests to read-only partitions") was lifted in commit a32e236e
    ("Partially revert "block: fail op_is_write() requests to read-only
    partitions"").  Basic things like user triggered writes and discards
    are still caught, but internal kernel users can submit anything.  In
    particular, ext4 will attempt to write to the superblock if it detects
    errors in the filesystem, even if the filesystem is mounted read-only
    on a read-only partition.
    
    The assert is overkill regardless.
    
    Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>