Skip to content
Snippets Groups Projects
Commit 1c23fbae authored by Milos Reljin's avatar Milos Reljin Committed by Frieder Schrempf
Browse files

net: phy: c45-tjaxx: add delay between MDIO write and read in soft_reset


commit bd1bbab717608757cccbbe08b0d46e6c3ed0ced5 upstream.

In application note (AN13663) for TJA1120, on page 30, there's a figure
with average PHY startup timing values following software reset.
The time it takes for SMI to become operational after software reset
ranges roughly from 500 us to 1500 us.

This commit adds 2000 us delay after MDIO write which triggers software
reset. Without this delay, soft_reset function returns an error and
prevents successful PHY init.

Cc: stable@vger.kernel.org
Fixes: b050f2f1 ("phy: nxp-c45: add driver for tja1103")
Signed-off-by: default avatarMilos Reljin <milos_reljin@outlook.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/AM8P250MB0124D258E5A71041AF2CC322E1E32@AM8P250MB0124.EURP250.PROD.OUTLOOK.COM


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6800d0fa
No related branches found
No related tags found
1 merge request!191🤖 Sync Bot: Update v6.1-ktn to Latest Stable Kernel (v6.1.129)
...@@ -937,6 +937,8 @@ static int nxp_c45_soft_reset(struct phy_device *phydev) ...@@ -937,6 +937,8 @@ static int nxp_c45_soft_reset(struct phy_device *phydev)
if (ret) if (ret)
return ret; return ret;
usleep_range(2000, 2050);
return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1, return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1,
VEND1_DEVICE_CONTROL, ret, VEND1_DEVICE_CONTROL, ret,
!(ret & DEVICE_CONTROL_RESET), 20000, !(ret & DEVICE_CONTROL_RESET), 20000,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment