Skip to content
Snippets Groups Projects
Commit 1fe9ca93 authored by Yu Zhao's avatar Yu Zhao Committed by Frieder Schrempf
Browse files

mm/mglru: fix div-by-zero in vmpressure_calc_level()

commit 8b671fe1 upstream.

evict_folios() uses a second pass to reclaim folios that have gone through
page writeback and become clean before it finishes the first pass, since
folio_rotate_reclaimable() cannot handle those folios due to the
isolation.

The second pass tries to avoid potential double counting by deducting
scan_control->nr_scanned.  However, this can result in underflow of
nr_scanned, under a condition where shrink_folio_list() does not increment
nr_scanned, i.e., when folio_trylock() fails.

The underflow can cause the divisor, i.e., scale=scanned+reclaimed in
vmpressure_calc_level(), to become zero, resulting in the following crash:

  [exception RIP: vmpressure_work_fn+101]
  process_one_work at ffffffffa3313f2b

Since scan_control->nr_scanned has no established semantics, the potential
double counting has minimal risks.  Therefore, fix the problem by not
deducting scan_control->nr_scanned in evict_folios().

Link: https://lkml.kernel.org/r/20240711191957.939105-1-yuzhao@google.com


Fixes: 359a5e14 ("mm: multi-gen LRU: retry folios written back while isolated")
Reported-by: default avatarWei Xu <weixugc@google.com>
Signed-off-by: default avatarYu Zhao <yuzhao@google.com>
Cc: Alexander Motin <mav@ixsystems.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c4d370ee
No related branches found
No related tags found
1 merge request!162🤖 Sync Bot: Update v6.1-ktn to Latest Stable Kernel (v6.1.103)
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment