Skip to content
Snippets Groups Projects
Commit 336dc9d3 authored by Paul Geurts's avatar Paul Geurts Committed by Frieder Schrempf
Browse files

serial: imx: fix tx statemachine deadlock


[ Upstream commit 78d60dae ]

When using the serial port as RS485 port, the tx statemachine is used to
control the RTS pin to drive the RS485 transceiver TX_EN pin. When the
TTY port is closed in the middle of a transmission (for instance during
userland application crash), imx_uart_shutdown disables the interface
and disables the Transmission Complete interrupt. afer that,
imx_uart_stop_tx bails on an incomplete transmission, to be retriggered
by the TC interrupt. This interrupt is disabled and therefore the tx
statemachine never transitions out of SEND. The statemachine is in
deadlock now, and the TX_EN remains low, making the interface useless.

imx_uart_stop_tx now checks for incomplete transmission AND whether TC
interrupts are enabled before bailing to be retriggered. This makes sure
the state machine handling is reached, and is properly set to
WAIT_AFTER_SEND.

Fixes: cb1a6092 ("serial: imx: implement rts delaying for rs485")
Signed-off-by: default avatarPaul Geurts <paul_geurts@live.nl>
Tested-by: default avatarRasmus Villemoes <rasmus.villemoes@prevas.dk>
Tested-by: default avatarEberhard Stoll <eberhard.stoll@gmx.de>
Link: https://lore.kernel.org/r/AM0PR09MB26758F651BC1B742EB45775995B8A@AM0PR09MB2675.eurprd09.prod.outlook.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ea555207
No related branches found
No related tags found
1 merge request!125🤖 Sync Bot: Update v5.10-ktn to Latest Stable Kernel (v5.10.209)
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment