Skip to content
Snippets Groups Projects
Commit 3b676aad authored by Alexander Shiyan's avatar Alexander Shiyan Committed by Frieder Schrempf
Browse files

arm64: dts: rockchip: Fix broken tsadc pinctrl names for rk3588

commit 5c8f9a05336cf5cadbd57ad461621b386aadb762 upstream.

The tsadc driver does not handle pinctrl "gpio" and "otpout".
Let's use the correct pinctrl names "default" and "sleep".
Additionally, Alexey Charkov's testing [1] has established that
it is necessary for pinctrl state to reference the &tsadc_shut_org
configuration rather than &tsadc_shut for the driver to function correctly.

[1] https://lkml.org/lkml/2025/1/24/966



Fixes: 32641b8a ("arm64: dts: rockchip: add rk3588 thermal sensor")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarDragan Simic <dsimic@manjaro.org>
Signed-off-by: default avatarAlexander Shiyan <eagle.alexander923@gmail.com>
Link: https://lore.kernel.org/r/20250130053849.4902-1-eagle.alexander923@gmail.com


Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ddfbbebc
No related branches found
No related tags found
1 merge request!192🤖 Sync Bot: Update v6.12-ktn to Latest Stable Kernel (v6.12.17)
...@@ -2626,9 +2626,9 @@ tsadc: tsadc@fec00000 { ...@@ -2626,9 +2626,9 @@ tsadc: tsadc@fec00000 {
rockchip,hw-tshut-temp = <120000>; rockchip,hw-tshut-temp = <120000>;
rockchip,hw-tshut-mode = <0>; /* tshut mode 0:CRU 1:GPIO */ rockchip,hw-tshut-mode = <0>; /* tshut mode 0:CRU 1:GPIO */
rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */ rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */
pinctrl-0 = <&tsadc_gpio_func>; pinctrl-0 = <&tsadc_shut_org>;
pinctrl-1 = <&tsadc_shut>; pinctrl-1 = <&tsadc_gpio_func>;
pinctrl-names = "gpio", "otpout"; pinctrl-names = "default", "sleep";
#thermal-sensor-cells = <1>; #thermal-sensor-cells = <1>;
status = "disabled"; status = "disabled";
}; };
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment