-
- Downloads
xsk: Add TX timestamp and TX checksum offload support
This change actually defines the (initial) metadata layout that should be used by AF_XDP userspace (xsk_tx_metadata). The first field is flags which requests appropriate offloads, followed by the offload-specific fields. The supported per-device offloads are exported via netlink (new xsk-flags). The offloads themselves are still implemented in a bit of a framework-y fashion that's left from my initial kfunc attempt. I'm introducing new xsk_tx_metadata_ops which drivers are supposed to implement. The drivers are also supposed to call xsk_tx_metadata_request/xsk_tx_metadata_complete in the right places. Since xsk_tx_metadata_{request,_complete} are static inline, we don't incur any extra overhead doing indirect calls. The benefit of this scheme is as follows: - keeps all metadata layout parsing away from driver code - makes it easy to grep and see which drivers implement what - don't need any extra flags to maintain to keep track of what offloads are implemented; if the callback is implemented - the offload is supported (used by netlink reporting code) Two offloads are defined right now: 1. XDP_TXMD_FLAGS_CHECKSUM: skb-style csum_start+csum_offset 2. XDP_TXMD_FLAGS_TIMESTAMP: writes TX timestamp back into metadata area upon completion (tx_timestamp field) XDP_TXMD_FLAGS_TIMESTAMP is also implemented for XDP_COPY mode: it writes SW timestamp from the skb destructor (note I'm reusing hwtstamps to pass metadata pointer). The struct is forward-compatible and can be extended in the future by appending more fields. Reviewed-by:Song Yoong Siang <yoong.siang.song@intel.com> Signed-off-by:
Stanislav Fomichev <sdf@google.com> Acked-by:
Jakub Kicinski <kuba@kernel.org> Link: https://lore.kernel.org/r/20231127190319.1190813-3-sdf@google.com Signed-off-by:
Alexei Starovoitov <ast@kernel.org>
Showing
- Documentation/netlink/specs/netdev.yaml 18 additions, 1 deletionDocumentation/netlink/specs/netdev.yaml
- include/linux/netdevice.h 2 additions, 0 deletionsinclude/linux/netdevice.h
- include/linux/skbuff.h 13 additions, 1 deletioninclude/linux/skbuff.h
- include/net/xdp_sock.h 110 additions, 0 deletionsinclude/net/xdp_sock.h
- include/net/xdp_sock_drv.h 13 additions, 0 deletionsinclude/net/xdp_sock_drv.h
- include/net/xsk_buff_pool.h 6 additions, 0 deletionsinclude/net/xsk_buff_pool.h
- include/uapi/linux/if_xdp.h 38 additions, 0 deletionsinclude/uapi/linux/if_xdp.h
- include/uapi/linux/netdev.h 16 additions, 0 deletionsinclude/uapi/linux/netdev.h
- net/core/netdev-genl.c 12 additions, 1 deletionnet/core/netdev-genl.c
- net/xdp/xsk.c 34 additions, 0 deletionsnet/xdp/xsk.c
- net/xdp/xsk_queue.h 1 addition, 1 deletionnet/xdp/xsk_queue.h
- tools/include/uapi/linux/if_xdp.h 47 additions, 5 deletionstools/include/uapi/linux/if_xdp.h
- tools/include/uapi/linux/netdev.h 16 additions, 0 deletionstools/include/uapi/linux/netdev.h
- tools/net/ynl/generated/netdev-user.c 19 additions, 0 deletionstools/net/ynl/generated/netdev-user.c
- tools/net/ynl/generated/netdev-user.h 3 additions, 0 deletionstools/net/ynl/generated/netdev-user.h
Loading
Please register or sign in to comment