Skip to content
Snippets Groups Projects
Commit 65f1f57f authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini
Browse files

KVM: selftests: Verify stats fd can be dup()'d and read


Expand the binary stats test to verify that a stats fd can be dup()'d
and read, to (very) roughly simulate userspace passing around the file.
Adding the dup() test is primarily an intermediate step towards verifying
that userspace can read VM/vCPU stats before _and_ after userspace closes
its copy of the VM fd; the dup() test itself is only mildly interesting.

Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Message-Id: <20230711230131.648752-7-seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 47d1be8a
No related branches found
No related tags found
No related merge requests found
...@@ -232,17 +232,23 @@ int main(int argc, char *argv[]) ...@@ -232,17 +232,23 @@ int main(int argc, char *argv[])
} }
/* /*
* Check stats read for every VM and vCPU, with a variety of testcases. * Check stats read for every VM and vCPU, with a variety of flavors.
* Note, stats_test() closes the passed in stats fd. * Note, stats_test() closes the passed in stats fd.
*/ */
for (i = 0; i < max_vm; ++i) { for (i = 0; i < max_vm; ++i) {
/*
* Verify that creating multiple userspace references to a
* single stats file works and doesn't cause explosions.
*/
vm_stats_fds = vm_get_stats_fd(vms[i]); vm_stats_fds = vm_get_stats_fd(vms[i]);
stats_test(dup(vm_stats_fds));
/* Verify userspace can instantiate multiple stats files. */ /* Verify userspace can instantiate multiple stats files. */
stats_test(vm_get_stats_fd(vms[i])); stats_test(vm_get_stats_fd(vms[i]));
for (j = 0; j < max_vcpu; ++j) { for (j = 0; j < max_vcpu; ++j) {
vcpu_stats_fds[j] = vcpu_get_stats_fd(vcpus[i * max_vcpu + j]); vcpu_stats_fds[j] = vcpu_get_stats_fd(vcpus[i * max_vcpu + j]);
stats_test(dup(vcpu_stats_fds[j]));
stats_test(vcpu_get_stats_fd(vcpus[i * max_vcpu + j])); stats_test(vcpu_get_stats_fd(vcpus[i * max_vcpu + j]));
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment