-
- Downloads
locking/atomics: COCCINELLE/treewide: Convert trivial ACCESS_ONCE() patterns...
locking/atomics: COCCINELLE/treewide: Convert trivial ACCESS_ONCE() patterns to READ_ONCE()/WRITE_ONCE() Please do not apply this to mainline directly, instead please re-run the coccinelle script shown below and apply its output. For several reasons, it is desirable to use {READ,WRITE}_ONCE() in preference to ACCESS_ONCE(), and new code is expected to use one of the former. So far, there's been no reason to change most existing uses of ACCESS_ONCE(), as these aren't harmful, and changing them results in churn. However, for some features, the read/write distinction is critical to correct operation. To distinguish these cases, separate read/write accessors must be used. This patch migrates (most) remaining ACCESS_ONCE() instances to {READ,WRITE}_ONCE(), using the following coccinelle script: ---- // Convert trivial ACCESS_ONCE() uses to equivalent READ_ONCE() and // WRITE_ONCE() // $ make coccicheck COCCI=/home/mark/once.cocci SPFLAGS="--include-headers" MODE=patch virtual patch @ depends on patch @ expression E1, E2; @@ - ACCESS_ONCE(E1) = E2 + WRITE_ONCE(E1, E2) @ depends on patch @ expression E; @@ - ACCESS_ONCE(E) + READ_ONCE(E) ---- Signed-off-by:Mark Rutland <mark.rutland@arm.com> Signed-off-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: davem@davemloft.net Cc: linux-arch@vger.kernel.org Cc: mpe@ellerman.id.au Cc: shuah@kernel.org Cc: snitzer@redhat.com Cc: thor.thayer@linux.intel.com Cc: tj@kernel.org Cc: viro@zeniv.linux.org.uk Cc: will.deacon@arm.com Link: http://lkml.kernel.org/r/1508792849-3115-19-git-send-email-paulmck@linux.vnet.ibm.com Signed-off-by:
Ingo Molnar <mingo@kernel.org>
Showing
- arch/arc/kernel/smp.c 1 addition, 1 deletionarch/arc/kernel/smp.c
- arch/arm/include/asm/spinlock.h 1 addition, 1 deletionarch/arm/include/asm/spinlock.h
- arch/arm/mach-tegra/cpuidle-tegra20.c 1 addition, 1 deletionarch/arm/mach-tegra/cpuidle-tegra20.c
- arch/arm/vdso/vgettimeofday.c 1 addition, 1 deletionarch/arm/vdso/vgettimeofday.c
- arch/ia64/include/asm/spinlock.h 4 additions, 4 deletionsarch/ia64/include/asm/spinlock.h
- arch/mips/include/asm/vdso.h 1 addition, 1 deletionarch/mips/include/asm/vdso.h
- arch/mips/kernel/pm-cps.c 1 addition, 1 deletionarch/mips/kernel/pm-cps.c
- arch/mn10300/kernel/mn10300-serial.c 2 additions, 2 deletionsarch/mn10300/kernel/mn10300-serial.c
- arch/parisc/include/asm/atomic.h 1 addition, 1 deletionarch/parisc/include/asm/atomic.h
- arch/powerpc/platforms/powernv/opal-msglog.c 1 addition, 1 deletionarch/powerpc/platforms/powernv/opal-msglog.c
- arch/s390/include/asm/spinlock.h 3 additions, 3 deletionsarch/s390/include/asm/spinlock.h
- arch/s390/lib/spinlock.c 8 additions, 8 deletionsarch/s390/lib/spinlock.c
- arch/sparc/include/asm/atomic_32.h 1 addition, 1 deletionarch/sparc/include/asm/atomic_32.h
- arch/tile/gxio/dma_queue.c 2 additions, 2 deletionsarch/tile/gxio/dma_queue.c
- arch/tile/include/gxio/dma_queue.h 1 addition, 1 deletionarch/tile/include/gxio/dma_queue.h
- arch/tile/kernel/ptrace.c 1 addition, 1 deletionarch/tile/kernel/ptrace.c
- arch/x86/entry/common.c 1 addition, 1 deletionarch/x86/entry/common.c
- arch/x86/entry/vdso/vclock_gettime.c 1 addition, 1 deletionarch/x86/entry/vdso/vclock_gettime.c
- arch/x86/events/core.c 1 addition, 1 deletionarch/x86/events/core.c
- arch/x86/include/asm/vgtod.h 1 addition, 1 deletionarch/x86/include/asm/vgtod.h
Loading
Please register or sign in to comment