-
- Downloads
hrtimer: fix rq->lock inversion (again)
It appears I inadvertly introduced rq->lock recursion to the hrtimer_start() path when I delegated running already expired timers to softirq context. This patch fixes it by introducing a __hrtimer_start_range_ns() method that will not use raise_softirq_irqoff() but __raise_softirq_irqoff() which avoids the wakeup. It then also changes schedule() to check for pending softirqs and do the wakeup then, I'm not quite sure I like this last bit, nor am I convinced its really needed. Signed-off-by:Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: paulus@samba.org LKML-Reference: <20090313112301.096138802@chello.nl> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
Showing
- include/linux/hrtimer.h 5 additions, 0 deletionsinclude/linux/hrtimer.h
- include/linux/interrupt.h 1 addition, 0 deletionsinclude/linux/interrupt.h
- kernel/hrtimer.c 34 additions, 21 deletionskernel/hrtimer.c
- kernel/sched.c 11 additions, 3 deletionskernel/sched.c
- kernel/softirq.c 1 addition, 1 deletionkernel/softirq.c
Loading
Please register or sign in to comment