-
- Downloads
wait_on_bit: add an acquire memory barrier
There are several places in the kernel where wait_on_bit is not followed by a memory barrier (for example, in drivers/md/dm-bufio.c:new_read). On architectures with weak memory ordering, it may happen that memory accesses that follow wait_on_bit are reordered before wait_on_bit and they may return invalid data. Fix this class of bugs by introducing a new function "test_bit_acquire" that works like test_bit, but has acquire memory ordering semantics. Signed-off-by:Mikulas Patocka <mpatocka@redhat.com> Acked-by:
Will Deacon <will@kernel.org> Cc: stable@vger.kernel.org Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- Documentation/atomic_bitops.txt 4 additions, 6 deletionsDocumentation/atomic_bitops.txt
- arch/x86/include/asm/bitops.h 21 additions, 0 deletionsarch/x86/include/asm/bitops.h
- include/asm-generic/bitops/generic-non-atomic.h 14 additions, 0 deletionsinclude/asm-generic/bitops/generic-non-atomic.h
- include/asm-generic/bitops/instrumented-non-atomic.h 12 additions, 0 deletionsinclude/asm-generic/bitops/instrumented-non-atomic.h
- include/asm-generic/bitops/non-atomic.h 1 addition, 0 deletionsinclude/asm-generic/bitops/non-atomic.h
- include/asm-generic/bitops/non-instrumented-non-atomic.h 1 addition, 0 deletionsinclude/asm-generic/bitops/non-instrumented-non-atomic.h
- include/linux/bitops.h 1 addition, 0 deletionsinclude/linux/bitops.h
- include/linux/buffer_head.h 1 addition, 1 deletioninclude/linux/buffer_head.h
- include/linux/wait_bit.h 4 additions, 4 deletionsinclude/linux/wait_bit.h
- kernel/sched/wait_bit.c 1 addition, 1 deletionkernel/sched/wait_bit.c
Loading
Please register or sign in to comment