Skip to content
Snippets Groups Projects
Commit 93b26052 authored by Dan Carpenter's avatar Dan Carpenter Committed by Andy Gross
Browse files

soc: qcom: cmd-db: Fix an error code in cmd_db_dev_probe()


The memremap() function doesn't return error pointers, it returns NULL.
This code is returning "ret = PTR_ERR(NULL);" which is success, but it
should return -ENOMEM.

Fixes: 312416d9 ("drivers: qcom: add command DB driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarAndy Gross <andy.gross@linaro.org>
parent 9324df58
No related branches found
No related tags found
No related merge requests found
...@@ -248,8 +248,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev) ...@@ -248,8 +248,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev)
} }
cmd_db_header = memremap(rmem->base, rmem->size, MEMREMAP_WB); cmd_db_header = memremap(rmem->base, rmem->size, MEMREMAP_WB);
if (IS_ERR_OR_NULL(cmd_db_header)) { if (!cmd_db_header) {
ret = PTR_ERR(cmd_db_header); ret = -ENOMEM;
cmd_db_header = NULL; cmd_db_header = NULL;
return ret; return ret;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment