Skip to content
Snippets Groups Projects
Commit ac6ad7c2 authored by Pan Bian's avatar Pan Bian Committed by Bjorn Andersson
Browse files

bus: qcom: Put child node before return


Put child node before return to fix potential reference count leak.
Generally, the reference count of child is incremented and decremented
automatically in the macro for_each_available_child_of_node() and should
be decremented manually if the loop is broken in loop body.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Fixes: 335a1275 ("bus: qcom: add EBI2 driver")
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Link: https://lore.kernel.org/r/20210121114907.109267-1-bianpan2016@163.com


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent ddd6b726
No related branches found
No related tags found
No related merge requests found
...@@ -353,8 +353,10 @@ static int qcom_ebi2_probe(struct platform_device *pdev) ...@@ -353,8 +353,10 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
/* Figure out the chipselect */ /* Figure out the chipselect */
ret = of_property_read_u32(child, "reg", &csindex); ret = of_property_read_u32(child, "reg", &csindex);
if (ret) if (ret) {
of_node_put(child);
return ret; return ret;
}
if (csindex > 5) { if (csindex > 5) {
dev_err(dev, dev_err(dev,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment