-
- Downloads
block: disable entropy contributions for nonrot devices
Clear QUEUE_FLAG_ADD_RANDOM in all block drivers that set QUEUE_FLAG_NONROT. Historically, all block devices have automatically made entropy contributions. But as previously stated in commit e2e1a148 ("block: add sysfs knob for turning off disk entropy contributions"): - On SSD disks, the completion times aren't as random as they are for rotational drives. So it's questionable whether they should contribute to the random pool in the first place. - Calling add_disk_randomness() has a lot of overhead. There are more reliable sources for randomness than non-rotational block devices. From a security perspective it is better to err on the side of caution than to allow entropy contributions from unreliable "random" sources. Signed-off-by:Mike Snitzer <snitzer@redhat.com> Signed-off-by:
Jens Axboe <axboe@fb.com>
Showing
- drivers/block/mtip32xx/mtip32xx.c 1 addition, 0 deletionsdrivers/block/mtip32xx/mtip32xx.c
- drivers/block/nbd.c 1 addition, 0 deletionsdrivers/block/nbd.c
- drivers/block/null_blk.c 1 addition, 0 deletionsdrivers/block/null_blk.c
- drivers/block/nvme-core.c 1 addition, 0 deletionsdrivers/block/nvme-core.c
- drivers/block/rsxx/dev.c 1 addition, 0 deletionsdrivers/block/rsxx/dev.c
- drivers/block/skd_main.c 1 addition, 0 deletionsdrivers/block/skd_main.c
- drivers/block/zram/zram_drv.c 1 addition, 0 deletionsdrivers/block/zram/zram_drv.c
- drivers/ide/ide-disk.c 3 additions, 1 deletiondrivers/ide/ide-disk.c
- drivers/md/bcache/super.c 1 addition, 0 deletionsdrivers/md/bcache/super.c
- drivers/mmc/card/queue.c 1 addition, 0 deletionsdrivers/mmc/card/queue.c
- drivers/mtd/mtd_blkdevs.c 1 addition, 0 deletionsdrivers/mtd/mtd_blkdevs.c
- drivers/s390/block/scm_blk.c 1 addition, 0 deletionsdrivers/s390/block/scm_blk.c
- drivers/s390/block/xpram.c 1 addition, 0 deletionsdrivers/s390/block/xpram.c
- drivers/scsi/sd.c 3 additions, 1 deletiondrivers/scsi/sd.c
Loading
Please register or sign in to comment