-
- Downloads
can: Fix data length code handling in rx path
A valid CAN dataframe can have a data length code (DLC) of 0 .. 8 data bytes. When reading the CAN controllers register the 4-bit value may contain values from 0 .. 15 which may exceed the reserved space in the socket buffer! The ISO 11898-1 Chapter 8.4.2.3 (DLC field) says that register values > 8 should be reduced to 8 without any error reporting or frame drop. This patch introduces a new helper macro to cast a given 4-bit data length code (dlc) to __u8 and ensure the DLC value to be max. 8 bytes. The different handlings in the rx path of the CAN netdevice drivers are fixed. Signed-off-by:Oliver Hartkopp <oliver@hartkopp.net> Signed-off-by:
Wolfgang Grandegger <wg@grandegger.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- drivers/net/can/at91_can.c 1 addition, 1 deletiondrivers/net/can/at91_can.c
- drivers/net/can/bfin_can.c 1 addition, 1 deletiondrivers/net/can/bfin_can.c
- drivers/net/can/mcp251x.c 3 additions, 10 deletionsdrivers/net/can/mcp251x.c
- drivers/net/can/mscan/mscan.c 2 additions, 1 deletiondrivers/net/can/mscan/mscan.c
- drivers/net/can/sja1000/sja1000.c 8 additions, 10 deletionsdrivers/net/can/sja1000/sja1000.c
- drivers/net/can/ti_hecc.c 1 addition, 1 deletiondrivers/net/can/ti_hecc.c
- drivers/net/can/usb/ems_usb.c 1 addition, 1 deletiondrivers/net/can/usb/ems_usb.c
- include/linux/can/dev.h 9 additions, 0 deletionsinclude/linux/can/dev.h
Loading
Please register or sign in to comment