-
- Downloads
fs: configfs: don't return anything from drop_link
Documentation/filesystems/configfs/configfs.txt says: "When unlink(2) is called on the symbolic link, the source item is notified via the ->drop_link() method. Like the ->drop_item() method, this is a void function and cannot return failure." The ->drop_item() is indeed a void function, the ->drop_link() is actually not. This, together with the fact that the value of ->drop_link() is silently ignored suggests, that it is the ->drop_link() return type that should be corrected and changed to void. This patch changes drop_link() signature and all its users. Signed-off-by:Andrzej Pietrasiewicz <andrzej.p@samsung.com> [hch: reverted reformatting of some code] Signed-off-by:
Christoph Hellwig <hch@lst.de>
Showing
- Documentation/filesystems/configfs/configfs.txt 1 addition, 1 deletionDocumentation/filesystems/configfs/configfs.txt
- drivers/nvme/target/configfs.c 4 additions, 6 deletionsdrivers/nvme/target/configfs.c
- drivers/target/target_core_fabric_configfs.c 3 additions, 4 deletionsdrivers/target/target_core_fabric_configfs.c
- drivers/usb/gadget/configfs.c 3 additions, 5 deletionsdrivers/usb/gadget/configfs.c
- drivers/usb/gadget/function/uvc_configfs.c 5 additions, 20 deletionsdrivers/usb/gadget/function/uvc_configfs.c
- include/linux/configfs.h 1 addition, 1 deletioninclude/linux/configfs.h
Loading
Please register or sign in to comment