Skip to content
Snippets Groups Projects
Commit e190ae64 authored by Wentao Liang's avatar Wentao Liang Committed by Greg Kroah-Hartman
Browse files

mlxsw: Add return value check for mlxsw_sp_port_get_stats_raw()


commit fee5d688940690cc845937459e340e4e02598e90 upstream.

Add a check for the return value of mlxsw_sp_port_get_stats_raw()
in __mlxsw_sp_port_get_stats(). If mlxsw_sp_port_get_stats_raw()
returns an error, exit the function to prevent further processing
with potentially invalid data.

Fixes: 614d509a ("mlxsw: Move ethtool_ops to spectrum_ethtool.c")
Cc: stable@vger.kernel.org # 5.9+
Signed-off-by: default avatarWentao Liang <vulab@iscas.ac.cn>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Link: https://patch.msgid.link/20250212152311.1332-1-vulab@iscas.ac.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6888e683
No related branches found
No related tags found
No related merge requests found
...@@ -768,7 +768,9 @@ static void __mlxsw_sp_port_get_stats(struct net_device *dev, ...@@ -768,7 +768,9 @@ static void __mlxsw_sp_port_get_stats(struct net_device *dev,
err = mlxsw_sp_get_hw_stats_by_group(&hw_stats, &len, grp); err = mlxsw_sp_get_hw_stats_by_group(&hw_stats, &len, grp);
if (err) if (err)
return; return;
mlxsw_sp_port_get_stats_raw(dev, grp, prio, ppcnt_pl); err = mlxsw_sp_port_get_stats_raw(dev, grp, prio, ppcnt_pl);
if (err)
return;
for (i = 0; i < len; i++) { for (i = 0; i < len; i++) {
data[data_index + i] = hw_stats[i].getter(ppcnt_pl); data[data_index + i] = hw_stats[i].getter(ppcnt_pl);
if (!hw_stats[i].cells_bytes) if (!hw_stats[i].cells_bytes)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment