Skip to content
Snippets Groups Projects
Commit fcd30ae0 authored by Jonathan Lemon's avatar Jonathan Lemon Committed by Daniel Borkmann
Browse files

bpf/xskmap: Return ERR_PTR for failure case instead of NULL.


When kzalloc() failed, NULL was returned to the caller, which
tested the pointer with IS_ERR(), which didn't match, so the
pointer was used later, resulting in a NULL dereference.

Return ERR_PTR(-ENOMEM) instead of NULL.

Reported-by: default avatar <syzbot+491c1b7565ba9069ecae@syzkaller.appspotmail.com>
Fixes: 0402acd6 ("xsk: remove AF_XDP socket from map when the socket is released")
Signed-off-by: default avatarJonathan Lemon <jonathan.lemon@gmail.com>
Acked-by: default avatarBjörn Töpel <bjorn.topel@intel.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 8a03222f
No related branches found
No related tags found
No related merge requests found
......@@ -37,7 +37,7 @@ static struct xsk_map_node *xsk_map_node_alloc(struct xsk_map *map,
node = kzalloc(sizeof(*node), GFP_ATOMIC | __GFP_NOWARN);
if (!node)
return NULL;
return ERR_PTR(-ENOMEM);
err = xsk_map_inc(map);
if (err) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment