Skip to content
Snippets Groups Projects
Commit 37a2cf6f authored by Michal Simek's avatar Michal Simek
Browse files

tools: mkimage: Use fstat instead of stat to avoid malicious hacks


The patch is fixing:
"tools: mkimage: Check if file is regular file"
(sha1: 56c7e801)
which contains two issues reported by Coverity
Unchecked return value from stat and incorrect calling sequence where
attack can happen between calling stat and fopen.
Using pair in opposite order (fopen and fstat) is fixing this issue
because fstat is using the same file descriptor (FILE *).

Also fixing issue with:
"tools: mkimage: Add support for initialization table for Zynq and
ZynqMP" (sha1: 3b646080)
where file wasn't checked that it is regular file.

Reported-by: Coverity (CID: 154711, 154712)
Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
Reviewed-by: default avatarTom Rini <trini@konsulko.com>
Series-to: trini
Series-cc: u-boot
parent 8814c038
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment